[cherry-pick: release-v1.3.x] fix: panic in v1beta1 matrix validation for invalid result refs#9260
Open
tekton-robot wants to merge 1 commit intorelease-v1.3.xfrom
Open
[cherry-pick: release-v1.3.x] fix: panic in v1beta1 matrix validation for invalid result refs#9260tekton-robot wants to merge 1 commit intorelease-v1.3.xfrom
tekton-robot wants to merge 1 commit intorelease-v1.3.xfrom
Conversation
Collaborator
Author
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/kind bug |
Member
|
/retest |
5 similar comments
Member
|
/retest |
Member
|
/retest |
Member
|
/retest |
Member
|
/retest |
Member
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #9135
This fix applies the same safety check that was added to v1 pipelines in PR #8089. The validateMatrixedPipelineTaskConsumed function was panicking when encountering invalid variable substitutions like "$(tasks)-$(tasks.echo-result.results.output)" because it tried to access subExpressions[1] without first checking if the expression was a valid result reference.
The fix adds a check to skip expressions that don't look like result references before attempting to parse them, preventing the panic and allowing the webhook to return a proper validation error instead.
Related: #8089
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes